Skip to content

Conversation

@sashton
Copy link

@sashton sashton commented Aug 11, 2012

Added the option in Rect to support having corner radius applied to individual corners.
Added the same features to Image.

Both classes have the same drawPath() function. They are exactly the same, and could be refactored to a common location. I was unsure of the best location for such a function.

(First pull request, let me know if I need to do something differently)

@ericdrowell
Copy link
Owner

I like where you're going with this, but there are a couple of big changes that I'd like to make:

  1. I want to create a reusable rounded corner path method in the Rect shape that Image can leverage when doing the clipping.

  2. I want the rounded corners to be specified as an array rather than an object, like [12, 0, 10, 15], or [12, 10], or 12 for all corners to be rounded with a 12px radius.

@thewriteleague
Copy link

Has any further work on this item been completed? Haven't seen any updates here or in the docs and would love to be using the array version that you mentioned Eric.

@ericdrowell
Copy link
Owner

not yet, this is bit of a lower priority than other items.

@thewriteleague
Copy link

I figured. If i was able to help out i would. Thanks for the message.Eric Rowell notifications@github.com wrote:not yet, this is bit of a lower priority than other items.


Reply to this email directly or view it on GitHub.

@ericdrowell
Copy link
Owner

I'll be adding all of the corner radius enhancements in the next release, v4.4.4. Hopefully, I'll be able to find a clean, consistent solution to handle corner radius for rect, image, and Label, without adding overhead. Thanks again for working on this with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants