soap_version/0 now loads :version 1.1 by default#108
Open
waseigo wants to merge 1 commit intoelixir-soap:masterfrom
Open
soap_version/0 now loads :version 1.1 by default#108waseigo wants to merge 1 commit intoelixir-soap:masterfrom
waseigo wants to merge 1 commit intoelixir-soap:masterfrom
Conversation
In partial response to [issue 88](elixir-soap#88), I noticed that Soap fails completely if my application does not define `config :soap, :globals` in its `config/config.exs`, even though a) HTTPoison is the default client and b) version 1.1 is claimed in the documentation to be the default. Applications using a dependency that itself depends on Soap should not need to add anything to their `config/config.exs`, especially if what is expected to be defined therein has a sane default value (version 1.1, and HTTPoison), I redefined `soap_version/0` to first see if it can fetch its configuration; if not, it gracefully returns the (default, according to the docs) version 1.1. Note that the test suite of Soap still assumes that `config/config.exs` contains a configuration. Removing these lines from it makes tests fail. It might be a good idea to get rid of this caveat entirely, and follow the official recommendation to [avoid application configuration for libraries](https://hexdocs.pm/elixir/library-guidelines.html#avoid-application-configuration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In partial response to issue 88, I noticed that Soap fails completely if my application does not define
config :soap, :globalsin itsconfig/config.exs, even though a) HTTPoison is the default client and b) version 1.1 is claimed in the documentation to be the default.Applications using a dependency that itself depends on Soap should not need to add anything to their
config/config.exs, especially if what is expected to be defined therein has a sane default value (version 1.1, and HTTPoison). Thus, I redefinedsoap_version/0to first see if it can fetch its configuration; if not, it gracefully returns the (default, according to the docs) version 1.1.Note that the test suite of Soap still assumes that
config/config.exscontains a configuration. Removing these lines from it makes tests fail. It might be a good idea to get rid of this caveat entirely, and follow the official recommendation to avoid application configuration for libraries.