Skip to content

Fixing glitching pixels #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kgleeson wants to merge 2 commits into from
Closed

Fixing glitching pixels #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3c7f14
Fixing glitching pixels
kgleeson Mar 30, 2014
8372a43
Changing values to use BYTESPERPIXEL
kgleeson Mar 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions hardware/ws2812/neopixel.device.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* WS2812 "Neopixel" LED Driver
/* WS2812 "Neopixel" LED Driver
* Copyright (C) 2014 Electric Imp, inc.
*
* Uses SPI to emulate 1-wire
Expand Down Expand Up @@ -27,7 +27,7 @@ class NeoPixels {
// copied in directly, instead of being built for each pixel - which makes the class faster.
bits = null;
// Like bits, this blob holds the waveform to send the color [0,0,0], to clear pixels faster
clearblob = blob(24);
clearblob = blob(BYTESPERPIXEL);

// private variables passed into the constructor
spi = null; // imp SPI interface (pre-configured)
Expand All @@ -39,7 +39,7 @@ class NeoPixels {
constructor(_spi, _frameSize) {
this.spi = _spi;
this.frameSize = _frameSize;
this.frame = blob(frameSize*27 + 1);
this.frame = blob(frameSize*BYTESPERPIXEL + 1);

// prepare the bits array and the clearblob blob
initialize();
Expand Down Expand Up @@ -67,7 +67,7 @@ class NeoPixels {
}

// now fill the clearblob
for(local j = 0; j < 24; j++) {
for(local j = 0; j < BYTESPERPIXEL; j++) {
clearblob.writen(ZERO, 'b');
}
// must have a null at the end to drive MOSI low
Expand Down