Feature/GitHub action py linting (#2)#13
Closed
thoroc wants to merge 0 commit intoeasydiffusion:mainfrom
thoroc:main
Closed
Feature/GitHub action py linting (#2)#13thoroc wants to merge 0 commit intoeasydiffusion:mainfrom thoroc:main
thoroc wants to merge 0 commit intoeasydiffusion:mainfrom
thoroc:main
Conversation
cmdr2
reviewed
Feb 14, 2023
| datefmt="%X" | ||
| ) | ||
|
|
||
| from .file_utils import ( |
Contributor
There was a problem hiding this comment.
Why have these imports been deleted?
cmdr2
reviewed
Feb 14, 2023
| @@ -1,17 +0,0 @@ | |||
| from .model_loader import ( | |||
Contributor
There was a problem hiding this comment.
Why has this file been deleted? It's intended to create the API under sdkit.models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opened PR following rebase of the branch.
What
The meat of the changes are really in the
.github/workflow/py-lint.yml. All the python file have been modified either by runnning locally the following:black tests scripts sdkit examples --line-length 120 --include="\.py"isort tests scripts sdkit examples --profile blackautoflake --in-place --remove-all-unused-imports --remove-unused-variables --recursive .or following the recommendation of:
flake8 tests scripts sdkit examples --max-line-length 120 --extend-ignore=E203,E402,E501,E722,W391 --per-file-ignores=__init__.py:F401Why
To get some code formatting standardisation.
Introducing a python linting & formatting stage using black, isort, flake8 and autoflake. On new PR the workflow will run through those tool to check the formatting and linting of the code. black, isort and autoflake should autoformat/lint the code and flake8 will conduct additional code formatting checks.