Feature/GitHub action Python formatting/linting#11
Closed
thoroc wants to merge 0 commit intoeasydiffusion:mainfrom
thoroc:main
Closed
Feature/GitHub action Python formatting/linting#11thoroc wants to merge 0 commit intoeasydiffusion:mainfrom thoroc:main
thoroc wants to merge 0 commit intoeasydiffusion:mainfrom
thoroc:main
Conversation
cmdr2
reviewed
Feb 13, 2023
| actual_file_name = file_name(i) if callable(file_name) else f"{file_name}_{i}" | ||
| path = os.path.join(dir_path, actual_file_name) | ||
|
|
||
| if output_format.lower() == 'embed' and file_format.lower() == 'png': |
Contributor
There was a problem hiding this comment.
Can you please rebase your branch with the latest changes in main? I think it's missing the recent changes for metadata embedding (and is therefore removing these changes). Thanks
Contributor
|
Thanks, looks good. Please pull the latest changes from |
Contributor
Author
|
Apologies I had to close this PR. I'll need to reopen it with the rebase from cb49807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration of what a github action for code formatting/linting would do. Currently using the following:
All rules subject to discussion.
All code changes due to the rules above applied to it.