[mono][jit] AndNot and ConditionalSelect Intrinsics#84677
Closed
LeVladIonescu wants to merge 0 commit intodotnet:mainfrom
Closed
[mono][jit] AndNot and ConditionalSelect Intrinsics#84677LeVladIonescu wants to merge 0 commit intodotnet:mainfrom
LeVladIonescu wants to merge 0 commit intodotnet:mainfrom
Conversation
LeVladIonescu
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
vargaz
reviewed
Apr 12, 2023
src/mono/mono/mini/mini-arm64.c
Outdated
vargaz
approved these changes
Apr 12, 2023
jandupej
approved these changes
Apr 12, 2023
Member
fanyang-mono
left a comment
fanyang-mono
left a comment
There was a problem hiding this comment.
Overall, looks good to me, except the coding style that Zoltan pointed out. And please merge main to your branch to get my latest change before merging.
LeVladIonescu
force-pushed
the
intrinsics
branch
from
33a3f3f to
887c043
Compare
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #80566.