Only check inexact match when no exact match is found.#39961
Only check inexact match when no exact match is found.#39961yyjdelete wants to merge 1 commit intodotnet:masterfrom
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @roji, @ajcvickers |
|
Tests? |
|
Infact, I don't know how and where to create an test for this internal api. And maybe it's not a problem due to it's internal and there is no dupe tables with different case actually used by public apis. |
David-Engel
left a comment
There was a problem hiding this comment.
I wouldn't close this PR just because you aren't adding tests. The bug is valid and benefits from being fixed, even though it doesn't surface with the existing *.SqlMetaData.xml embedded resources.
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbMetaDataFactory.cs
Show resolved
Hide resolved
|
@cheenamalhotra this PR is pretty old now -- what's the next step? |
|
Since we don't have System.Data.SqlClient anymore, it can be closed. |
Fix #39620
Avoid the exact match result be overwrite by later inexact ones.
This may not happen due to limited callsites, just make the code more clear.