Skip to content

docs(ipc-protocol): document SetEnvironmentVariable #5674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tommcdon merged 4 commits into from
Jan 1, 2026
Merged

docs(ipc-protocol): document SetEnvironmentVariable #5674

tommcdon merged 4 commits into from
Jan 1, 2026
+45 −1

Conversation

@fuguiKz
Copy link
Contributor

@fuguiKz fuguiKz commented Dec 28, 2025

Adds the missing Process SetEnvironmentVariable command section (0x0403) to documentation/design-docs/ipc-protocol.md.

Fixes #5664.

@fuguiKz fuguiKz requested a review from a team as a code owner December 28, 2025 12:26
@fuguiKz fuguiKz mentioned this pull request Dec 28, 2025
Closed
tommcdon
tommcdon requested changes Dec 28, 2025
View reviewed changes
documentation/design-docs/ipc-protocol.md Outdated

Header: `{ Magic; size; 0xFF00; 0x0000; }`

There is no payload.
Copy link
Member

@tommcdon tommcdon Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There is no payload.
`SetEnvironmentVariable` returns:
* `int32 hresult`: The result of setting the environment variable (`0` indicates success)

@fuguiKz
Copy link
Contributor Author

fuguiKz commented Dec 29, 2025

Thanks for the review! I applied both suggestions: the SetEnvironmentVariable docs now describe the returned int32 hresult (and added a Details "Returns" payload snippet) in commit 3b5b3aa.

tommcdon
tommcdon reviewed Dec 29, 2025
View reviewed changes
@tommcdon
Copy link
Member

tommcdon commented Dec 29, 2025

Thanks for the review! I applied both suggestions: the SetEnvironmentVariable docs now describe the returned int32 hresult (and added a Details "Returns" payload snippet) in commit 3b5b3aa.

Thanks @fuguiKz! I have added one more suggestion then I think this change is ready!

@fuguiKz
Copy link
Contributor Author

fuguiKz commented Jan 1, 2026

Applied the remaining suggestion (add > Available since .NET 6.0 for SetEnvironmentVariable) in commit 345fcea. Thanks again — would appreciate a re-review when you have a chance.

tommcdon
tommcdon approved these changes Jan 1, 2026
View reviewed changes
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tommcdon tommcdon merged commit 6efc893 into dotnet:main Jan 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommcdon tommcdon tommcdon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IPC Protocol Specification missing Process SetEnvironmentVariable section

2 participants

@fuguiKz @tommcdon