Skip to content

set ContentLength when forwarding requests #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericcurtin wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

set ContentLength when forwarding requests #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/inference/scheduling/http_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,14 @@ func (h *HTTPHandler) handleOpenAIInference(w http.ResponseWriter, r *http.Reque
}()

// Create a request with the body replaced for forwarding upstream.
// Set ContentLength explicitly so the backend always receives a Content-Length
// header. Without this, HTTP/2 requests (where clients may omit Content-Length)
// are forwarded with Transfer-Encoding: chunked, which some backends (e.g.
// vLLM's Python/uvicorn server) fail to parse, resulting in an empty body and
// a 422 response.
upstreamRequest := r.Clone(r.Context())
upstreamRequest.Body = io.NopCloser(bytes.NewReader(body))
upstreamRequest.ContentLength = int64(len(body))

// Perform the request.
runner.ServeHTTP(w, upstreamRequest)
Expand Down