Skip to content

Update "content" copy to be more defensive of exact subdirectory names#8

Merged
yosifkit merged 1 commit intodocker-library:masterfrom
infosiftr:more-defensive-copy
Apr 7, 2015
Merged

Update "content" copy to be more defensive of exact subdirectory names#8
yosifkit merged 1 commit intodocker-library:masterfrom
infosiftr:more-defensive-copy

Conversation

@tianon
Copy link
Member

@tianon tianon commented Apr 6, 2015

This is an update to the logic introduced in #6 to be more defensive if upstream decides to change the names of the subdirectories of "content" (or more likely, add more).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is that same as before, but do we want to check for an empty directory rather than existence?

Copy link
Member Author

@tianon tianon Apr 6, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianon tianon force-pushed the more-defensive-copy branch from 0da0855 to 2fb73b3 Compare April 6, 2015 23:56
@yosifkit
Copy link
Member

yosifkit commented Apr 7, 2015

LGTM

yosifkit added a commit that referenced this pull request Apr 7, 2015
Update "content" copy to be more defensive of exact subdirectory names
@yosifkit yosifkit merged commit c63006a into docker-library:master Apr 7, 2015
@yosifkit yosifkit deleted the more-defensive-copy branch April 7, 2015 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants