Generate VCD file for each cover statement

[ShashankVM]

Fixes #1287

[ShashankVM]

Hi Project Maintainers!

I've been using EBMC for hobby projects for a year now. The VCD file generation for each cover statement was a feature that I sorely missed in my projects.

I've implemented this feature and verified it is working locally. I've attached the screenshot of the results.

I'm looking forward to contributing to this project and welcome feedback!

[kroening]

This regresses on the current behavior, where you can get the trace in a file named as the argument of --vcd. The user still needs to give an argument to the --vcd switch, which will be ignored.

[ShashankVM]

Thanks for your feedback. @kroening

Do we want to keep the argument for VCD filename?

If yes, I can include the filename argument as a suffix in the final filename.

If not, I can work on modifying the command line parsing logic. Please let me know how to proceed.

[kroening]

Thanks for your feedback. @kroening

Do we want to keep the argument for VCD filename?

If yes, I can include the filename argument as a suffix in the final filename.

This is what we are doing for --random-traces (look at random_traces.cpp, line 169).

However, making that change would still regress the current behaviour. I am not opposed to this in principle, but we'd need to do this as part of a major version release. Let's do it.

[ShashankVM]

Thanks for your feedback. @kroening
Do we want to keep the argument for VCD filename?
If yes, I can include the filename argument as a suffix in the final filename.

This is what we are doing for --random-traces (look at random_traces.cpp, line 169).

However, making that change would still regress the current behaviour. I am not opposed to this in principle, but we'd need to do this as part of a major version release. Let's do it.

I've copied code over from random_traces.cpp file and verified that it now implements adding filename argument as a prefix, similar to random traces.

[ShashankVM]

All whitespace changes reverted and looks good to me.

[kroening]

Please apply git-clang-format.

[ShashankVM]

Please apply git-clang-format.

Thanks, I have run this command before pushing my changes.

[ShashankVM]

Reviewed all suggested changes and updated the code. Thanks for the quick code review!

[kroening]

BTW, please squash the commits into one, then this is ready to merge.

[ShashankVM]

I've tried squashing the commits into one by reading an online tutorial. Hope this worked.

[ShashankVM]

I'm still seeing 16 commits, looks like the squash didn't work?

[ShashankVM]

I can try squashing the commits again tomorrow if required.

[kroening]

Try this:

git checkout vcd_for_all_cover
git reset --soft origin/main
git commit -m "Generate VCD file for each cover statement"
git push --force