Switching back to app does not hide splash screen #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems the plugin was not swizzling AppDelegate, but simply overriding it. This means it all worked fine and dandy as long as no other plugins were overriding or swizzling AppDelegates applicationWillResignActive or applicationDidBecomeActive. Sadly, phonegap-plugin-push and many more do exactly this... so the combination was causing one or both plugins to fail. This change fixes the swizzling in this plugin, making it play nicely with phonegap-plugin-push, and hopefully others. Coincidentally, phonegap-plugin-push was also incorrectly overriding applicationDidBecomeActive, so I have sent a PR to correct phonegap-plugin-push as well.
Contributor
|
We could do this without swizzling at all. I can send a PR of that approach if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Seems the plugin was not swizzling AppDelegate, but simply overriding
it.
This means it all worked fine and dandy as long as no other plugins were
overriding or swizzling AppDelegates applicationWillResignActive or
applicationDidBecomeActive.
Sadly, phonegap-plugin-push and many more do exactly this... so the
combination was causing one or both plugins to fail.
This change fixes the swizzling in this plugin, making it play nicely
with phonegap-plugin-push, and hopefully others.
Coincidentally, phonegap-plugin-push was also incorrectly overriding
applicationDidBecomeActive, so I have sent a PR to correct
phonegap-plugin-push as well.