Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devgeeks/PrivacyScreenPlugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: devgeeks/PrivacyScreenPlugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: issue-12
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Mar 1, 2016

  1. Switching back to app does not hide splash screen 

    Seems the plugin was not swizzling AppDelegate, but simply overriding
it.

This means it all worked fine and dandy as long as no other plugins were
overriding or swizzling AppDelegates applicationWillResignActive or
applicationDidBecomeActive.

Sadly, phonegap-plugin-push and many more do exactly this... so the
combination was causing one or both plugins to fail.

This change fixes the swizzling in this plugin, making it play nicely
with phonegap-plugin-push, and hopefully others.

Coincidentally, phonegap-plugin-push was also incorrectly overriding
applicationDidBecomeActive, so I have sent a PR to correct
phonegap-plugin-push as well.
    @devgeeks
    devgeeks committed Mar 1, 2016
    Configuration menu
    Copy the full SHA
    5f2a01f View commit details
    Browse the repository at this point in the history
Loading