Skip to content

Code review feedback #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omriAckley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code review feedback #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions client/components/Snippet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,24 @@ class Snippet extends Component {
}

runCode() {
//promise.resolve can't catch this error if there is one.
//Bluebird.try
/*or new Promise((resolve, reject) => {
try {
eval(this.state.value)
resolve()
}
catch {
reject()
}
})*/
Promise.resolve(eval(this.state.value))
.then(result => this.setState({ result }))
.catch(err => console.error('Error running code: ', err));
}

saveCode() {
//be aware of firebase versus firestore
const codesRef = firebase.database().ref('codes');
codesRef.push({
name: 'anonymous',
Expand Down
2 changes: 1 addition & 1 deletion client/crud/user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const db = require('../../firebase/initFirebase');
require('firebase/firestore');
require('firebase/firestore'); //is this needed?

// Add a user to the database
export const addUserFunction = (userObj) => {
Expand Down