Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| func selectDockerImage(cfg projectConfig) (string, string) { | ||
| switch { | ||
| case cfg.Extensions.PostGIS && cfg.Extensions.Timescale && !cfg.Extensions.PGVector: | ||
| return "timescale/timescaledb-ha:pg16.2-ts2.14.2", "Includes TimescaleDB and PostGIS support." | ||
| case cfg.Extensions.PostGIS && !cfg.Extensions.PGVector && !cfg.Extensions.Timescale: | ||
| return "postgis/postgis:16-3.4", "Includes PostGIS support." | ||
| case cfg.Extensions.PGVector && !cfg.Extensions.PostGIS && !cfg.Extensions.Timescale: | ||
| return "pgvector/pgvector:pg16", "Includes the pgvector extension." | ||
| case cfg.Extensions.Timescale && !cfg.Extensions.PostGIS && !cfg.Extensions.PGVector: | ||
| return "timescale/timescaledb-ha:pg16.2-ts2.14.2", "Includes TimescaleDB support." | ||
| default: | ||
| return "postgres:16", "Use a custom image to bundle additional extensions." |
There was a problem hiding this comment.
The Docker image selector falls back to plain postgres:16 whenever timescaledb and pgvector are both enabled, even though renderExtensionSQL still emits CREATE EXTENSION timescaledb. The stock Postgres image does not ship with TimescaleDB, so the generated docker-compose.yml will start a container that immediately fails when the init SQL runs. selectDockerImage should prefer a TimescaleDB-capable image whenever Timescale is true (and then document that pgvector must be added manually) rather than dropping support entirely when pgvector is also requested.
Useful? React with 👍 / 👎.
1 participant
Summary
erm docker synccommand that writes docker/local assets based on erm.yamlerm initcall the shared sync helper so projects start with docker/local/docker-compose.yml and extension SQLTesting
https://chatgpt.com/codex/tasks/task_b_68f2104cc608832eaa3b22e6f1bea836