refactor: support output failed log of ebpf loading and degrade into profiler-common when profiler-5.2_plus load failed #11082
+106
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
kernel v5.2： kernel v5.4： kernel v5.15： |
yinjiping
reviewed
Dec 23, 2025
| obj->license, obj->kern_version, 0, NULL, | ||
| 0 /*EBPF_LOG_LEVEL, log_buf, LOG_BUF_SZ */ ); | ||
| resume_stderr(stderr_fd); | ||
| if (new_prog->prog_fd < 0) { |
Contributor
There was a problem hiding this comment.
https://github.com/iovisor/bcc/blob/b1335d1ed479ebbae738c46d90dcce5adcb3dbb1/src/cc/libbpf.c#L938
bcc_prog_load（）内部实现已经考虑到这种情况，看看能不能把标准错误直接输出到一个临时文件
Contributor
Author
There was a problem hiding this comment.
已去掉额外的verifier日志尾部打印，保持原先的正常错误输出，只将完整错误日志写到临时文件
kylewanginchina
force-pushed
the
support-debug-ebpf-load
branch
from
74544c4 to
41ae68c
Compare
kylewanginchina
force-pushed
the
support-debug-ebpf-load
branch
from
41ae68c to
7d65ac5
Compare
kylewanginchina
changed the title
Contributor
Author
|
加入了加载出错自动降级的逻辑，效果如下图所示： 另外，错误信息文件输出这块，对于指令非常多（超出1000000）导致加载出错的情况，会比较耗时，比如下图中耗时： |
continuous-profiler-5.2_plus load failed
kylewanginchina
force-pushed
the
support-debug-ebpf-load
branch
from
7d65ac5 to
addb59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for:
Support output the debug log of failed ebpf loading into temporary file.
Support degrade into continuous-profiler-common when continuous-profiler-5.2_plus load failed
Checklist
Backport to branches