Tags: debnil/go
Tags
Check if multiple filters are set (stellar#995) This commit fixes multiple issues with parameter handling in actions. The main problem was connected to `base.GetString` method that gets values from the URLParams, form or query string (in this order). It was possible that extra GET parameter changed the internal query. For example: ``` /ledgers/100/effects?account_id=GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H ``` doesn't return effects for ledger 100 but for a given account ID because if `account_id` is set the rest of the parameters are ignored (`switch`). Obviously, this is not how the actions should be used but for extra security this should be fixed. To solve this issue: * We count applied filters, if it's larger than 1 we return `400 Bad Request` response. * We ensure that `tx_id` parameter is only checked in URL params. Additionally, we ensure that transaction hash is valid (if passed). * We ensure that `include_failed` parameter is only checked in GET params.
Offers schema 9 (stellar#972) Updates offer table queries to use new Core DB schema 9 (stellar/stellar-core#1957). It also fixes SignersByAddress to support NULL values (close stellar#967).
PreviousNext