Conversation
|
@davidancor I found your Assignment 1 in the assignment branch, but since you haven’t created a PR for it, I am not able to review and comment formally. I’ll drop some comments here:
Note: Assignments will not be graded if no PR is created. I made an exception this time, but please make sure to open a PR for each branch you create for each assignment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TITLE: UofT-DSI | SQL - Assignment 2
What changes are you trying to make?
I am adding 2 ERD PNGs for a book store logical model. 1 is without shifts and one is with shift. I am also uploading 1 .md file and 1 .sql file with answers to the required questions.
What did you learn from the changes you have made?
I learned that UPDATE/INSERT/DELETE don't show output. I had to add SELECT afterward to verify changes. I also learned that multiple SQL approaches can achieve the same result.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Yes, I considered using ROW_NUMBER() with SELECT DISTINCT instead of DENSE_RANK() with GROUP BY, but stuck with GROUP BY to match the class examples.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The correlated UPDATE subquery was tricky, I had to combine ORDER BY with LIMIT 1 and remember COALESCE for null values.
How were these changes tested?
Ran SELECT statements before and after each change to verify the results.
A reference to a related issue in your repository (if applicable)
Checklist