add instructions to remove aliases without reboot #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-r-reis
approved these changes
Sep 5, 2022
Contributor
|
@adutra do you want to give this a go on your Mac just as a simple check before we merge this? |
adutra
suggested changes
Sep 5, 2022
Contributor
adutra
left a comment
adutra
left a comment
There was a problem hiding this comment.
I wonder if we shouldn't redesign the example scripts a bit. Opening 255 addresses on 4 subnets is too much and will definitely incur in the mdns responder issue described in the text (it does on my machine).
I'd suggest to change the snippets and:
- Only open aliases in 2 subnets;
- Only open 50 aliases in each subnet.
That's more than enough for most usages of Simulacron imo.
| #!/bin/bash | ||
| for sub in {0..4}; do | ||
| echo "Opening for 127.0.$sub" | ||
| for i in {0..255}; do sudo ifconfig lo0 -alias 127.0.$sub.$i; done |
Contributor
There was a problem hiding this comment.
Suggested change
| for i in {0..255}; do sudo ifconfig lo0 -alias 127.0.$sub.$i; done | |
| for i in {0..255}; do sudo ifconfig lo0 -alias 127.0.$sub.$i down; done |
Contributor
There was a problem hiding this comment.
Also note: this is bringing 127.0.0.0 and 127.0.0.1 down. I don't know if that's safe, even if 127.0.0.1 is being brought up again later in the same script.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.