Skip to content

MENDELU/Fix UI Details #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milanmajchrak merged 12 commits into from
Jan 5, 2026
Merged

MENDELU/Fix UI Details #1167

milanmajchrak merged 12 commits into from
Jan 5, 2026

Conversation

@jr-rk
Copy link

@jr-rk jr-rk commented Jan 5, 2026 •
edited
Loading

Problem description

  • Remove / Hide copyright info from footer as wished
  • Hide startup message in browser console for production environments
  • Remove unused admin components and menu providers causing 401 errors for anonymous item page viewers
  • Hide REST self-link mismatch warnings in production by wrapping console.warn calls with environment.production checks in DspaceRestResponseParsingService

FE unit (spec) tests fixes

  • Fix ItemPageCitationFieldComponent test by replacing non-existent iframeSrc property check with correct citaceProURL$ and citaceProStatus$ properties
  • Fix PublicationComponent tests by adding ConfigurationDataService mock required by ItemPageCitationFieldComponent to prevent HALEndpointService errors
  • Fix FooterComponent tests by adding ConfigurationDataService mock and moving FooterComponent from providers to imports as standalone component to resolve Store NullInjectorError
  • Fix ContactPageComponent tests by moving standalone component to imports, adding ActivatedRoute mock, and correcting property name from 'lr.help.mail' to 'mail.helpdesk'

Copilot review

  • Requested review from Copilot

@jr-rk jr-rk self-assigned this Jan 5, 2026
@jr-rk jr-rk requested a review from Copilot January 5, 2026 09:41
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the copyright information from the footer of the MENDELU custom theme as requested. The change is a simple one-line removal that hides the copyright text while keeping the surrounding DSpace and LYRASIS links intact.

  • Removes the copyright notice with dynamic year from the footer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jr-rk jr-rk requested a review from Copilot January 5, 2026 11:11
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jr-rk
Hide REST self-link mismatch warnings in production by wrapping conso…
aa9390d 
…le.warn calls with environment.production checks in DspaceRestResponseParsingService
@jr-rk jr-rk requested a review from Copilot January 5, 2026 12:13
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jr-rk added 4 commits January 5, 2026 13:17
@jr-rk
Fix ItemPageCitationFieldComponent test by replacing non-existent ifr…
fa9ec3d 
…ameSrc property check with correct citaceProURL$ and citaceProStatus$ properties
@jr-rk
Fix PublicationComponent tests by adding ConfigurationDataService moc…
dc0b5a2 
…k required by ItemPageCitationFieldComponent to prevent HALEndpointService errors
@jr-rk
Fix FooterComponent tests by adding ConfigurationDataService mock and…
ccc0fe5 
… moving FooterComponent from providers to imports as standalone component to resolve Store NullInjectorError
@jr-rk
Fix ContactPageComponent tests by moving standalone component to impo…
04855bf 
…rts, adding ActivatedRoute mock, and correcting property name from 'lr.help.mail' to 'mail.helpdesk'
@jr-rk jr-rk requested a review from Copilot January 5, 2026 13:05
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jr-rk jr-rk requested a review from Copilot January 5, 2026 13:37
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jr-rk jr-rk requested a review from milanmajchrak January 5, 2026 13:45
milanmajchrak
milanmajchrak requested changes Jan 5, 2026
View reviewed changes
@jr-rk
WithdrawnReinstateItemMenuProvider - Guard admin-only menu and compon…
60908fe 
…ent API calls with authorization checks to prevent 401 errors for anonymous users
@milanmajchrak milanmajchrak requested a review from Copilot January 5, 2026 15:17
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milanmajchrak milanmajchrak merged commit 0cc0bcd into customer/mendelu Jan 5, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@milanmajchrak milanmajchrak milanmajchrak requested changes

Assignees

@jr-rk jr-rk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jr-rk @milanmajchrak