feat(util): add seed parameter for reproducible sampling #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional seed parameter to sample_proportions() and proportions_from_distribution() - Fix column_name parameter bug in proportions_from_distribution()
|
@jedwin3210 Thanks for rolling this so quickly. It looks great to me. I added @pancakereport as a reviewer |
pancakereport
approved these changes
Oct 30, 2025
Contributor
pancakereport
left a comment
pancakereport
left a comment
There was a problem hiding this comment.
Thanks Edwin, looks good.
My quick poking around the code shows that this is the only instance of np.random.default_rng()
Contributor
|
Actually - I think we should bump the version number. |
pancakereport
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Add optional seed parameter to sample_proportions() and proportions_from_distribution()
Fix column_name parameter bug in proportions_from_distribution()