feat: add invite funding key derivation path #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
requested changes
Aug 3, 2023
Collaborator
|
This should also update the DIP-9 table: https://github.com/dashpay/dips/blob/master/dip-0009/assignments.md |
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
HashEngineering
force-pushed
the
add-invite-funding-keys
branch
from
1967a27 to
1639276
Compare
Collaborator
Author
|
@thephez I have made the requested changes. |
thephez
reviewed
Sep 21, 2023
thephez
requested changes
Sep 25, 2023
Collaborator
thephez
left a comment
thephez
left a comment
There was a problem hiding this comment.
Can you also update the table of contents to include the new section? I just noticed it wasn't included there.
Collaborator
Author
|
@thephez I finally updated the PR based on your latest comments. |
thephez
reviewed
Dec 20, 2023
Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
requested changes
Dec 20, 2023
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
thephez
force-pushed
the
add-invite-funding-keys
branch
from
e6511ca to
3427fd2
Compare
thephez
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add invite funding key derivation paths to DIP13.