Open
Conversation
anjali-deshpande-hub
approved these changes
Nov 15, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Very well done! 68/70
Just one comment - Section 3 Delete: The requirement is to delete the older record for the product added.
You can use MIN(snapshot_timestamp) function. Using the WITH clause and MIN function, identify the earliest snapshot for the product_id and then delete the row that matches that product_id and timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding completed SQL for assignment 2 and the graph
What did you learn from the changes you have made?
There was a lot to learn in this assignment using window functions and NULL handling. Additions and modifications to tables and joins were also covered but used less frequently
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I'm not sure if I implemented the cross join correctly as it didn't seem necessary to get the same information. It was checked by looking at the cross join output and doing manual calculations of the expected values for the products.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The longest time I spent on the questions was the update section. Trying to figure out how to find the most recent entry for the product in a neat fashion and use it took some time. I ended up testing outputs from different methods and chose what I think looked the cleanest
How were these changes tested?
Segmented testing of code
A reference to a related issue in your repository (if applicable)
Checklist