Fix Docker container race condition during upgrades

[andrasbacsai]

Changes

• Stop and remove existing Coolify containers before starting new ones in both scripts/upgrade.sh and other/nightly/upgrade.sh
• Prevents volume and container name conflicts when upgrading from installations with different Docker Compose project names

Issues

• Fixes container conflicts for users upgrading from older Coolify versions where Docker Compose inferred project name from directory

[djsisson]

if you're taking down, make sure you run docker pull beforehand, otherwise any error from the registry (rate limit, token expired) will mean it won't come back up again.

[andrasbacsai]

if you're taking down, make sure you run docker pull beforehand, otherwise any error from the registry (rate limit, token expired) will mean it won't come back up again.

Thanks.

For my changes: Not sure if this is the best option, but also not sure what else we can do tbh.

[djsisson]

perhaps only take down and rm if the project is not coolify
only pull helper before hand if not same version
then run compose pull let compose handle pulling
also you can switch to --use-api-socket this auto mounts the socket and config.json

# --- Pull helper image ---
docker pull "${REGISTRY_URL:-ghcr.io}/coollabsio/coolify-helper:${LATEST_HELPER_VERSION}" \
  >> "$LOGFILE" 2>&1 || { echo "Failed to pull helper image. Aborting upgrade." >> "$LOGFILE"; exit 1; }

echo "Running docker compose via helper..." >> "$LOGFILE"
docker run -v /data/coolify/source:/data/coolify/source \
           --use-api-socket \
           --rm \
           "${REGISTRY_URL:-ghcr.io}/coollabsio/coolify-helper:${LATEST_HELPER_VERSION}" \
           bash -c "
             set -e
             LATEST_IMAGE=${LATEST_IMAGE}

             # Build compose file arguments dynamically
             COMPOSE_FILES='-f /data/coolify/source/docker-compose.yml -f /data/coolify/source/docker-compose.prod.yml'
             if [ -f /data/coolify/source/docker-compose.custom.yml ]; then
               COMPOSE_FILES=\"\$COMPOSE_FILES -f /data/coolify/source/docker-compose.custom.yml\"
             fi

             # Step 1: Pull images first
             docker compose --project-name coolify \
                            --env-file /data/coolify/source/.env \
                            \$COMPOSE_FILES pull

             # Step 2: Check project labels of known containers
             WRONG_PROJECT=false
             for c in coolify coolify-db coolify-redis coolify-realtime; do
               if docker ps -a --format '{{.Names}}' | grep -q \"^\$c\$\"; then
                 PNAME=\$(docker inspect -f '{{ index .Config.Labels \"com.docker.compose.project\" }}' \"\$c\" 2>/dev/null)
                 if [ \"\$PNAME\" != \"coolify\" ]; then
                   echo \"Container \$c has wrong project (\$PNAME). Will run compose down.\" >> /proc/1/fd/1
                   WRONG_PROJECT=true
                   break
                 fi
               fi
             done

             # Step 3: If wrong project detected, run down before up
             if [ \"\$WRONG_PROJECT\" = true ]; then
               docker compose --project-name coolify \
                              --env-file /data/coolify/source/.env \
                              \$COMPOSE_FILES down --remove-orphans
             fi

             # Step 4: Finally bring services up
             docker compose --project-name coolify \
                            --env-file /data/coolify/source/.env \
                            \$COMPOSE_FILES up -d --remove-orphans --wait --wait-timeout 60
           " >> "$LOGFILE" 2>&1