Skip to content

UofT-DSI | Python - Assignment One#1

Open
cookiejars8 wants to merge 1 commit intomainfrom
assignment-one
Open

UofT-DSI | Python - Assignment One#1
cookiejars8 wants to merge 1 commit intomainfrom
assignment-one

Conversation

@cookiejars8
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

answering questions part 1 and two

What did you learn from the changes you have made?

strings and proving to be true/false

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

n/a

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

not sure what to name each anagram - stuck with str1 and str2

How were these changes tested?

with the execute

A reference to a related issue in your repository (if applicable)

Checklist

  • [Y ] I can confirm that my changes are working as intended

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Your code is clean, well-documented, and well-written and your PR description is clear. Your assignment 1 is complete – no changes needed.

Please see my suggestion for future improvement: I suggest adding comments or brief documentation to your code. It’s a good practice that makes it easier for you to review and debug later, and helps teammates understand it quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants