cleaning unnecesary injections within MainActivity, updating build tools and dependencies#7
Open
eduardogr wants to merge 7 commits intocodepath:masterfrom
eduardogr:master
Open
cleaning unnecesary injections within MainActivity, updating build tools and dependencies#7eduardogr wants to merge 7 commits intocodepath:masterfrom eduardogr:master
eduardogr wants to merge 7 commits intocodepath:masterfrom
eduardogr:master
Conversation
…jects cleaning unnecesary injections within MainActivity
This was referenced Jun 20, 2019
rogerhu
reviewed
Jun 21, 2019
app/build.gradle
Outdated
| buildToolsVersion "23.0.3" | ||
| compileSdkVersion 28 | ||
| buildToolsVersion '28.0.3' | ||
|
|
Member
There was a problem hiding this comment.
You can remove this line now. It's not needed
rogerhu
reviewed
Jun 21, 2019
build.gradle
Outdated
| repositories { | ||
| jcenter() | ||
| maven { | ||
| url 'https://maven.google.com/' |
Member
There was a problem hiding this comment.
You can use google() now in Gradle
rogerhu
reviewed
Jun 21, 2019
build.gradle
Outdated
| allprojects { | ||
| repositories { | ||
| jcenter() | ||
| maven { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.