Add strategic emojis and fix registry update issue #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Add strategic emojis to key sections for better UX: - 🔨 Welcome header for create and help commands - 📁 Installation directory prompt - 🏷️ App name prompt - 👤 Profile name section - 🌐 DNS mapping rules section - 📋 Summary section - 📦 App bundle creation - 📱 Found apps in list command - 📭 No apps found message • Fix critical registry update bug in remove_app function: - Add || true to read commands to prevent early exit - Add || true to registry manipulation commands - Registry now properly updates when removing apps - Apps are correctly removed from tracking system 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
• Add conditional execution to PNG validation workflow • Check git diff for .png file changes in PRs and pushes • Skip expensive PNG analysis when no images are modified • Add informative skip message to explain CI optimization • Update comprehensive test summary to handle skipped state • Improves CI performance and resource usage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
cjflory
added a commit
that referenced
this pull request
Aug 24, 2025
• Fix profile name suggestion to preserve hyphens in app names - Updated regex to include hyphens in allowed characters - Apps like "my-dev-app" now generate profile name "my-dev-app" - Previously hyphens were stripped, causing inconsistent naming • Bump version from 2.1.0 to 2.2.0 for recent feature additions: - Strategic emoji enhancements throughout UI (PR #11, #12) - Registry bug fix for proper app removal (PR #11) - CI optimization for PNG analysis (PR #11) - Default behavior change to help-first (PR #12) - Profile name generation improvement (this PR) Minor version bump reflects significant UX improvements and new functionality while maintaining backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds strategic emoji improvements to enhance user experience, fixes a critical bug in the app removal functionality, and optimizes CI performance by making PNG analysis conditional.
UI Improvements
• Strategic emoji placement - Added contextually appropriate emojis to key user interaction points:
• Consistent branding - Maintains the same visual theme across all command outputs
• Clean implementation - One emoji per section as requested, avoiding visual clutter
Critical Bug Fix
• Registry update failure - Fixed issue where
remove_appcommand wasn't updating the registry• Root cause -
set -eflag was causing script to exit early whenreadcommands or file operations failed• Solution - Added
|| trueto critical commands to ensure execution continues to registry update• Impact - Apps are now properly removed from the tracking system instead of becoming orphaned entries
CI Performance Optimization
• Smart PNG analysis - PNG file validation now only runs when PNG files are actually changed
• Conditional execution - Checks git diff for
.pngfile changes in PRs and pushes• Resource savings - Skips expensive image analysis tools installation when not needed
• Clear feedback - Shows informative skip message when PNG analysis is bypassed
• Better performance - Faster CI runs for code-only changes
Technical Details
Test Results
🤖 Generated with Claude Code