Skip to content

Assignment 2#5

Open
chevrie4 wants to merge 5 commits intomainfrom
assignment-2
Open

Assignment 2#5
chevrie4 wants to merge 5 commits intomainfrom
assignment-2

Conversation

@chevrie4
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code to complete the assignment

What did you learn from the changes you have made?

The directory needed to be updated to make the CSVs relative to the python notebook location.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Modified the directory for the CSVs by adding "../../../"

How were these changes tested?

By checking the various functions on each of the CSVs and comparing manually with the raw data on Excel

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@chevrie4
Copy link
Owner Author

Apologies for the delayed submission - busy week!

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few changes required:

  1. Question 3: The call to check_zeros inside detect_zeros function is missing.
  2. The output block is visible, but the call that gives the output is missing from the code block. Screenshot attached:
    Screenshot 2025-05-17 143640
  3. Lastly, Changes to assignment_1.ipynb should not be included in this pull request.
    Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419 to fix this.

@chevrie4
Copy link
Owner Author

Hi @anjali-deshpande-hub, sorry for the delayed reply to your request. I've made the requested changes to assignment 2 (and 1) and added the commits to this branch. Please let me know if there are any outstanding issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants