Open
Conversation
Owner
Author
|
Apologies for the delayed submission - busy week! |
anjali-deshpande-hub
suggested changes
May 17, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Looks good! Just a few changes required:
- Question 3: The call to
check_zerosinsidedetect_zerosfunction is missing. - The output block is visible, but the call that gives the output is missing from the code block. Screenshot attached:

- Lastly, Changes to assignment_1.ipynb should not be included in this pull request.
Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419 to fix this.
Owner
Author
|
Hi @anjali-deshpande-hub, sorry for the delayed reply to your request. I've made the requested changes to assignment 2 (and 1) and added the commits to this branch. Please let me know if there are any outstanding issues. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code to complete the assignment
What did you learn from the changes you have made?
The directory needed to be updated to make the CSVs relative to the python notebook location.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Modified the directory for the CSVs by adding "../../../"
How were these changes tested?
By checking the various functions on each of the CSVs and comparing manually with the raw data on Excel
A reference to a related issue in your repository (if applicable)
Checklist