Conversation
juliagallucci
approved these changes
May 9, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good ! One note for improvement, sorted(word_a_lower) == sorted(word_b_lower) returns a boolean, so no need to include an if/else statement
Owner
Author
Thanks for reviewing and for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Resubmitting this pull request, as I accidentally merged the initial PR I created on May 05, 2025.
What did you learn from the changes you have made?
Not to merge a PR.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I reverted the original merge, but I also could have made a new branch and restaged/committed/pushed my assignment 1 to the new branch.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
As discussed above, accidental merge of the first PR.
How were these changes tested?
Previously tested using the sample anagram testing pairs.
A reference to a related issue in your repository (if applicable)
Checklist