Skip to content

uploading python assignment 1 (again)#4

Open
chevrie4 wants to merge 1 commit intomainfrom
assignment-1
Open

uploading python assignment 1 (again)#4
chevrie4 wants to merge 1 commit intomainfrom
assignment-1

Conversation

@chevrie4
Copy link
Owner

@chevrie4 chevrie4 commented May 9, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Resubmitting this pull request, as I accidentally merged the initial PR I created on May 05, 2025.

What did you learn from the changes you have made?

Not to merge a PR.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I reverted the original merge, but I also could have made a new branch and restaged/committed/pushed my assignment 1 to the new branch.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

As discussed above, accidental merge of the first PR.

How were these changes tested?

Previously tested using the sample anagram testing pairs.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ! One note for improvement, sorted(word_a_lower) == sorted(word_b_lower) returns a boolean, so no need to include an if/else statement

@chevrie4
Copy link
Owner Author

chevrie4 commented May 9, 2025

Good ! One note for improvement, sorted(word_a_lower) == sorted(word_b_lower) returns a boolean, so no need to include an if/else statement

Thanks for reviewing and for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants