Skip to content

Uploaded completed assignment 2#2

Open
ccmckenzie17 wants to merge 1 commit intomainfrom
assignment-2
Open

Uploaded completed assignment 2#2
ccmckenzie17 wants to merge 1 commit intomainfrom
assignment-2

Conversation

@ccmckenzie17
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

assignment_2.ipynb has been updated to meet all requirements including several additional checks.

What did you learn from the changes you have made?

I learned about reading in data and using functions to evaluate the data and check for errors

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

For part 3 I first made a detect_problems function that included a loop that checked if check_zeros == True and would return True else return False. But after looking closer and thinking about a comment from my first assignment about making code more concise I realized the same thing could be accomplished with a single simple line of "return check_zeros(patient_means)".

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Although I did not run into any major challenges with the basic requirements of the assignment it did give me lots of space to try other things and practice some other things I've learned in this module. (ie, adding a loop at the end of part 3 that checks all of the files).

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@tianyi21 tianyi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Cory,

✅ You implemented the function to read and display a file.
✅ You completed the patient_summary() function to summarize a file.
✅ You implemented the detect_problems() function to check the file.

🎉 Your A2 is complete!
🎊 All your Python assessments are now complete. Thank you for your participation, and I wish you all the best for your future!

Thanks,
Tianyi [LS]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants