Skip to content

Assignment 1#1

Open
ccmckenzie17 wants to merge 2 commits intomainfrom
assignment-1
Open

Assignment 1#1
ccmckenzie17 wants to merge 2 commits intomainfrom
assignment-1

Conversation

@ccmckenzie17
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Code was added for two versions of the anagram_checker function as well as some additional checks to ensure function works as intended.

What did you learn from the changes you have made?

I learned how to nest if loops into a function as well as string methods

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I chose to generate all of my variables at the beginning of the function and then in the loops I only evaluate the existing variables with operators. I think it would be possible to begin the function with the first if statement (i.e. "is_case_sensitive") and then generate only the necessary variables as the loop progresses.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Initially had a small error where I used the sorted function before the .lower() method but .lower() would not work on a list so I had to use that first on the original input strings before sorting.

How were these changes tested?

The functions were evaluated using the test calls provided as well as a couple additional checks for different anagrams (case sensitive and not case sensitive).

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, though your code could be simplified. For example, part b could be coded as:

if not is_case_sensitive:
word_a, word_b = word_a.lower(), word_b.lower()
return sorted(word_a) == sorted(word_b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants