Open
Conversation
juliagallucci
approved these changes
Oct 20, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good, though your code could be simplified. For example, part b could be coded as:
if not is_case_sensitive:
word_a, word_b = word_a.lower(), word_b.lower()
return sorted(word_a) == sorted(word_b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Code was added for two versions of the anagram_checker function as well as some additional checks to ensure function works as intended.
What did you learn from the changes you have made?
I learned how to nest if loops into a function as well as string methods
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I chose to generate all of my variables at the beginning of the function and then in the loops I only evaluate the existing variables with operators. I think it would be possible to begin the function with the first if statement (i.e. "is_case_sensitive") and then generate only the necessary variables as the loop progresses.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Initially had a small error where I used the sorted function before the .lower() method but .lower() would not work on a list so I had to use that first on the original input strings before sorting.
How were these changes tested?
The functions were evaluated using the test calls provided as well as a couple additional checks for different anagrams (case sensitive and not case sensitive).
A reference to a related issue in your repository (if applicable)
Checklist