Add unit tests for inet abbreviated key conversions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-inet-sortsupport-unit
branch
6 times, most recently
from
91f1559 to
fdf5286
Compare
brandur
force-pushed
the
brandur-inet-sortsupport
branch
from
5f1f4cf to
6755550
Compare
Implements SortSupport for the inet/cidr types in Postgres by devising an abbreviated key representation for them that will faithfully reproduce their existing sorting rules. This has the effect of typically reducing the time taken for inet/cidr sorts by ~50-60%, and should show a good improvement for the vast majority of real-world data sets.
brandur
force-pushed
the
brandur-inet-sortsupport-unit
branch
from
fdf5286 to
15172e0
Compare
Adds a new unit test suite that specifically checks the bit-level abbreviation for inet/cidr keys to help protect against subtle regressions that may still result in mostly successful sorts (therefore not breaking the main regression tests), but cause errors at the edges or degraded performance. This involves exposing a `network_abbrev_convert_var` function out of `network.c` to aid with testability.
brandur
force-pushed
the
brandur-inet-sortsupport
branch
from
6755550 to
5e0d24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new unit test suite that specifically checks the bit-level
abbreviation for inet/cidr keys to help protect against subtle
regressions that may still result in mostly successful sorts (therefore
not breaking the main regression tests), but cause errors at the edges
or degraded performance.
This involves exposing a
network_abbrev_convert_varfunction out ofnetwork.cto aid with testability.