Open
Conversation
zackhitch
approved these changes
Aug 9, 2018
| console.log("\nChallenge 1:"); | ||
| let fullName = []; | ||
|
|
||
| runners.forEach(function(element) { |
There was a problem hiding this comment.
Great job! Its good practice to assign this to a variable, so that you can reuse the data should you need to in the future. Example let runnerNames = runners.forEach(......
| let allCaps = []; | ||
| console.log("\nChallenge 2:"); | ||
| let allCaps = runners.map(function(runner) { | ||
| return runner["first_name"].toUpperCase(); |
| let largeShirts = []; | ||
| console.log("\nChallenge 3:"); | ||
| let largeShirts = runners.filter(function(runner) { | ||
| return runner["shirt_size"] === "L"; |
| // The donations need to be tallied up and reported for tax purposes. Add up all the donations into a ticketPriceTotal array and log the result | ||
| let ticketPriceTotal = []; | ||
| console.log("\nChallenge 4:"); | ||
| let ticketPriceTotal = runners.reduce(function(donationTotal, runner) { |
| console.log(PassedArgument); | ||
| } | ||
|
|
||
| firstItem(items, TestFunction1); |
| return cb(arr.length); | ||
| } | ||
|
|
||
| getLength(items, function(length) { |
| return cb(arr[arr.length - 1]); | ||
| } | ||
|
|
||
| last(items, function(lastWord) { |
| } | ||
|
|
||
| sumNums(2, 3, TestFunction1); | ||
|
|
| return cb(x * y); | ||
| } | ||
|
|
||
| multiplyNums(2, 3, TestFunction1); |
| if (item === list[i]) { | ||
| return cb(true); | ||
| } | ||
| return cb(false); |
There was a problem hiding this comment.
Great! I think just line just needs to be moved out of the for loop, so just after line 68.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zackhitch