Cristian Garcia JS-II#199
Open
2940cristian wants to merge 6 commits intobloominstituteoftechnology:masterfrom
Open
Cristian Garcia JS-II#1992940cristian wants to merge 6 commits intobloominstituteoftechnology:masterfrom
2940cristian wants to merge 6 commits intobloominstituteoftechnology:masterfrom
Conversation
2940cristian
changed the title
What Went Well:Nice work! You were able to make all the basic tests pass and took a healthy shot at the stretch. You obviously get the material, and your code is well written as well. Really solid commit frequency and messages as well. Keep it up!Areas For Improvement:The logic was close on checkMatchingLeaves. What you'll typically do is have some sort of boolean that is set to false if you encounter an item that isn't equal to the previous. The recursion comes if you encounter a key who's value is also an object. In that case you need to run checkMatchingLeaves on that object as well.Questions:None!Rating (1-3):2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.