[sukhada gholba] JavaScript-I#66
Open
sukhadagholba wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Open
[sukhada gholba] JavaScript-I#66sukhadagholba wants to merge 5 commits intobloominstituteoftechnology:masterfrom
sukhadagholba wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Conversation
bdurb
reviewed
May 22, 2018
| // The dealer can't recall the information for a car with an id of 33 on his lot. Help the dealer find out which car has an id of 33 by logging the car's year, make, and model in the console log provided to you below: | ||
| console.log(`Car 33 is a *car year goes here* *car make goes here* *car model goes here*` ); | ||
|
|
||
| console.log("Car 33 is a "+ inventory[32]["car_year"]+" "+ inventory[32]["car_make"]+" "+inventory[32]["car_model"]); |
There was a problem hiding this comment.
good use of referencing the index keeping in mind arrays start at 0.
bdurb
reviewed
May 22, 2018
| let lastCar = 0; | ||
| console.log(); | ||
| lastCar = inventory.length-1; | ||
| console.log("Make for the last car is "+inventory[lastCar]["car_make"]+" "+"and Model for the last car is "+inventory[lastCar]["car_model"]); |
There was a problem hiding this comment.
This looks good. You may want to look into string literals, it will make your life easier.
bdurb
reviewed
May 22, 2018
| //console.log(antonietta.multiplyNums(3,4)); | ||
|
|
||
| intern5.multiplyNums = function(a,b){ | ||
| return (a*b); |
There was a problem hiding this comment.
This is technically accurate, however, its best practices to leave spaces between elements. i.e. return (a * b).
|
@sukhadagholba thank you for the PR. Great work today, you are doing well with these concepts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.