Closed
Conversation
enitchals
reviewed
Apr 18, 2018
enitchals
left a comment
enitchals
left a comment
There was a problem hiding this comment.
Great job with this, April! You're developing good JS fundamentals. Please let me know if there are any particular concepts you want to review!
|
|
||
| // ==== Challenge 3 ==== | ||
| let lastCar = inventory[inventory.length-1]; | ||
| console.log("Make: " + lastCar.car_make + ", Model: " + lastCar.car_model); |
| // find cars older than the year 2000 => Condition | ||
| if (inventory[i].car_year < 2000) { | ||
| // return old cars in oldCar array | ||
| oldCars.push(inventory[i].car_year); // pushed over and over |
There was a problem hiding this comment.
Using comments like this effectively turns your old code into easy-access reference material for future projects, which is awesome!
| BMWAndAudi.push(inventory[i].car_make) | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The only thing you're missing is a line using JSON.stringify() (which turns a JS object/array into a string) and console.log() to print the result.
| function contains(item, list, cb) { | ||
| // contains checks if an item is present inside of the given array/list. | ||
| // Pass true to the callback if it is, otherwise pass false. | ||
| if(list.include(item)) { |
There was a problem hiding this comment.
Very close -- the method is includes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.