Jacob Lyerla#265
Open
JacobLeonLyerla wants to merge 16 commits intobloominstituteoftechnology:masterfrom
Open
Conversation
|
In callbacks.js for the contains function: Even though it passes the tests can you tell me what is logically wrong inside your for loop? In callbacks.js removeDuplicates function - which function did you already create that could be used here? In objects.js, you shouldn't use the built-in object methods, like Object.keys and Object.values, to solve a function of the same name and purpose. Great commenting but be aware of over commenting where the code is self-explanatory. ;) Keep up the outstanding work! Rating (0-3): 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not get to test my code yet but i feel ok, but i was a little unsure on a few parts.