This repository was archived by the owner on Aug 31, 2019. It is now read-only.
AdvancedJavaScript#7
Closed
sfmajors373 wants to merge 27 commits intobloominstituteoftechnology:masterfrom
Closed
Conversation
recursion: still broken
es6: trying to un-break it
Contributor
seanchen1991
left a comment
seanchen1991
left a comment
There was a problem hiding this comment.
Some minor comments, but looks good for the most part!
| // Combine all elements into a single value going from left to right. | ||
| // Elements will be passed one by one into `cb`. | ||
| // `memo` is the starting value. If `memo` is undefined then make `elements[0]` the initial value. | ||
| if (memo === undefined) { |
Contributor
There was a problem hiding this comment.
You can just do if (!memo) here.
| } | ||
| } | ||
| if (temp.length === 0) { | ||
| return undefined; |
Contributor
There was a problem hiding this comment.
If you just do return;, it's the same as doing return undefined;.
| return temp; | ||
| }; | ||
|
|
||
| const flatten = (elements) => { |
Contributor
There was a problem hiding this comment.
This implementation will only strip away one level of nesting. It needs to be able to strip away an arbitrary amount of nesting.
| // this method should take in a string and compare it to the object's password property | ||
| // return `true` if they match, otherwise return `false` | ||
| comparePasswords(word) { | ||
| if (word === this.password) { |
Contributor
There was a problem hiding this comment.
Here, you can just do return word === this.password;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Submitting for review.
Thanks!