Auction Module #11
Open
Auction Module #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelorc
reviewed
Nov 10, 2021
angelorc
requested changes
Nov 10, 2021
| string owner = 7; | ||
| uint32 limit = 8; | ||
| AuctionType auction_type = 2; | ||
| string nft_denom_id = 3; |
Contributor
There was a problem hiding this comment.
What do you think to replace it as we've done with the fantoken?
For example:
Denom => nft{HASH}
OldDenom => Collection
Contributor
There was a problem hiding this comment.
of course this question should be moved in the nft module
Contributor
Author
There was a problem hiding this comment.
Yeah, this discussion belongs to the nft module, not auction module.
Contributor
Author
There was a problem hiding this comment.
Can we handle this in another PR? @angelorc
Since this is related with nft module changes, not auction module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.