Feat: Auto patcher to aid in developemnt workflow and some docs changes#3
Closed
RunTheBot wants to merge 3 commits intobertigert:mainfrom
Closed
Feat: Auto patcher to aid in developemnt workflow and some docs changes#3RunTheBot wants to merge 3 commits intobertigert:mainfrom
RunTheBot wants to merge 3 commits intobertigert:mainfrom
Conversation
Owner
|
I was thinking about creating a setup script, will probably do that for the next update, however, I also need to rework the injection code, since it's overly complicated, so the patches will be outdated and besides, I also changed/added stuff other than the injection code. I'll leave this open so that I don't forget, but I won't merge it, since I don't like AI code and your provided scripts are all in the wrong path anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new plugin system for the Deezer desktop app, including a robust setup script, platform-aware plugin directory management, and improved documentation. The main changes are the addition of a
setup.jsinstaller script, a cross-platformpaths.jsutility, a comprehensiveplugin_loader.js, and updates to the documentation to guide users through the new process.Plugin System Implementation
src/plugin_loader.jsto handle dynamic loading and execution of plugins, with enhanced error handling and support for multiple plugin contexts (main,preload,renderer,titlebar).src/paths.jsto provide platform-specific paths for plugin storage, ensuring compatibility across Windows, macOS, and Linux.Installer and Setup Improvements
src/setup.js, a setup script that automates extraction, patching, and repacking of Deezer'sapp.asar, supports debug mode, and ensures plugins are correctly integrated and directories are created.Documentation Updates
docs/setup.mdto include new instructions for placingplugin_loader.jsandpaths.js, clarifying their location and role in the setup process.docs/setup.mdto clarify context usage for plugin execution, specifically for therendererandtitlebarcontexts.