Fix learning rate scheduler order #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

benbennett wants to merge 1 commit into main from codex/fix-learning-rate-scheduler-order

Owner

benbennett commented Sep 24, 2025

Summary

update BaseModel.update_learning_rate to accept the current epoch and adjust scheduler stepping accordingly
move learning rate updates in training loops to the end of each epoch so the optimizer steps precede scheduler steps

Testing

python -m compileall models/base_model.py simple.py atme.py

https://chatgpt.com/codex/tasks/task_e_68d371ef55708331b938ee60cd448348


          Fix learning rate scheduler order

fa083eb

benbennett added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels