support unicode filenames #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ah! Apologies for not checking outstanding pr's first. I'll take a look. |
Author
|
Ok, looks like yours is indeed much more comprehensive. Not sure I have anything to add at this point, but thanks for the quick response! Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem when one of my filenames was
u'file.ogg'rather than'file.ogg'(str).This patch swaps out the string type-check for
six.string_types. (I also threw it onmodewhile we're at it.)This does add a dependency on the
sixmodule, so I understand if you'd prefer to do it manually instead.Probably, there are other places where the code can be patched up to work more smoothly with unicode and/or general py2/py3 compatibility. I haven't done a thorough check though.