test #3
Open
test #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
basharkey
commented
Dec 19, 2023
basharkey
commented
- Tests written, or not not needed
Using the new `AdvancedX509KeyManager` class from the `nextcloud-android-library` to add support for servers that require a TLS client certificate to connect. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
Since the official nextcloud android-library does not have the new `AdvancedX509KeyManager`, the automated tests cannot build th e app. So for that I refer to my fork of the android-library for now. This commit shall be reverted before merge. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
All interaction with the nextcloud server is handled by the `NextCloudWebViewClient`, so TLS client certificate handling should be done by that class. Since `AuthenticatorActivity` only extends `NextCloudWebViewClient` with some additional methods, it is enough to have the certificate handling in one place. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
Isntead of having to find the hostname and port from an URL (which might be more tricky than expected), we now can simply pass down the URL and `AdvancedX509KeyManager` will take care of finding the port from the URL. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
Improving code quality a bit by avoiding magic numbers. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
The method `onReceivedHttpError` did have 3 exit points (`return`), but Codacy only allows us 2, so error handling for `request?.url` and `view?.context` was combined. Seems debatable, what's more readable, but the rules are the rules. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
The `nextcloud-android-library` uses version `8.1.2` of the gradle plugin, so we have to use the same version for successful builds. Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
This reverts commit a71fb01.
Run workflows
This reverts commit 94d7acb.
test workflows
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 90 days!
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Elv1zz
pushed a commit
to Elv1zz/nextcloud-android
that referenced
this pull request
Jan 12, 2024
## Description - Modify QA workflow to build APK and upload as an artifact - New workflow to create comment linking to artifact files You can download the artifact using the direct link but it requires OAuth so I would just recommend pulling it from the build log. Tested here: [basharkey#3](basharkey#3) ## Commits * useless commit * update qa to create release * uses * always publish and overwrite * personal token * update workflows * oops * use artifacts and comments * always run * enable * Revert "useless commit" This reverts commit a71fb01. * test workflows * Revert "test workflows" This reverts commit 94d7acb. * fix table
Elv1zz
pushed a commit
to Elv1zz/nextcloud-android
that referenced
this pull request
Jan 12, 2024
## Description - Modify QA workflow to build APK and upload as an artifact - New workflow to create comment linking to artifact files You can download the artifact using the direct link but it requires OAuth so I would just recommend pulling it from the build log. Tested here: [basharkey#3](basharkey#3) ## Commits * useless commit * update qa to create release * uses * always publish and overwrite * personal token * update workflows * oops * use artifacts and comments * always run * enable * Revert "useless commit" This reverts commit a71fb01. * test workflows * Revert "test workflows" This reverts commit 94d7acb. * fix table Signed-off-by: Elv1zz <elv1zz.git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.