Dev #2
Open
Dev #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Insert preliminary steps. - First interface of ClausePicker class To be tested
Has been changed the logic behind this function, because there is no reason to apply the resolution rule more than one time on the same pair of clauses. This is because if the resolution rule can be applied for example two times, it means that there are at least two distinct couple of complementary literals in the two clauses. When the resolution rule is applied to one these complementary literals in the resulting clause there will be the other two complementary literals so the clause can be removed because it is a tautology. The same result is obtained when the resolution rule is applied on the other couple of complementary literals. This theory needs to be verified.
Sort the couples of clauses with the sum of the sizes. With this has been saved one forth of execution time.
Now resolution_rule takes almost 1/30 of the time
Now resolution_rule takes almost 1/3 of the time less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final changes