Fix running on OSX #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An improper import was causing this to fail on osx, and likely win64, used same structure as core/kernel.py to fix this.
Remove hardcoded directory which would fail on many machines (especially osx/*nix) and switch to making a temporary directory programmatically.
Attempt to programmatically find 7zip and dexdump if the system is not Windows. Likely could make the need for calling either of these obsolete, however this is a short term fix to just allow it to run on osx.
Author
|
This should now be functional on osx (potentially also generic linux builds) assuming the environment it runs in has 7zip (7za) and dexdump on the normal PATH variable. |
Fix issue where sub windows would survive the main application window being exited.
Add locationization support and English translations for UI elements.
Author
|
I've added code to clean up the UI upon close event for the main window. Also added localization translation in the UI and the English translations |
Add localization support and add translations
Author
|
I've now added localization support in the protector dictionary and the translations. Unsure if you're assumptions in that file are correct or accurate - though I translated them and will work on improving them later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improper import was causing this to fail on osx, and
likely win64, used same structure as core/kernel.py
to fix this.