Skip to content

Change default to not include email on ecr login #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kgirthofer wants to merge 1 commit into from
Closed

Change default to not include email on ecr login #2813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions awscli/customizations/ecr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ class ECRLogin(BasicCommand):
'action': 'store_true',
'group_name': 'include-email',
'dest': 'include_email',
'default': True,
'default': False,
'required': False,
'help_text': (
"Specify if the '-e' flag should be included in the "
"'docker login' command. The '-e' option has been deprecated "
"and is removed in docker version 17.06 and later. You must "
"specify --no-include-email if you're using docker version "
"17.06 or later. The default behavior is to include the "
"17.06 or later. The default behavior is to not include the "
"'-e' flag in the 'docker login' output."),
},
{
Expand Down