Rename "invalid token" error to "jwt malformed" #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the message for a token with (for example) a trailing space into line with the listed potential error messages in the README.
Author
|
Any thoughts on this? |
| decodedToken = decode(jwtString, { complete: true }); | ||
| } catch(err) { | ||
| return done(err); | ||
| } |
DevLereko
reviewed
Mar 15, 2023
| var token = jwt.sign({ foo: 'bar' }, secret, { algorithm: 'HS256' }); | ||
|
|
||
| it('should return the "invalid token" error', function(done) { | ||
| it('should return the "jwt malformed" error with a trailing space', function(done) { |
There was a problem hiding this comment.
What might have happened to have the malformed JWT, it's because on my app, it has been working fine, and then lately I get jwt malformed error message, if I refresh the page, I will no longer see that error again, can you please give me details on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This brings the message for a token with (for example) a trailing space into line with the listed potential error messages in the README.
"invalid token" is confusing and not a listed possible error message -- is it invalid because it was corrupt, unauthorized, expired, etc.?
This also adds a test for the existing case where "jwt malformed" is returned, which was otherwise untested.
Checklist
master