feat: normalize query string for playwright engine #3665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfromanotherland
force-pushed
the
ed-normalize-query-string
branch
from
76b7a38 to
4f82894
Compare
This PR introduces query string improvements for Playwright tests, to reduce the number of distinct metrics a test run can generate and help users get more meaninful data out of a test. - `stripQueryString`: as seen in the `metrics-by-endpoint` http plugin, query strings can now be removed — it defaults to `false` - `normalizeQueryString`: defaults to `true`, prevents too many distinct metrics, can be explicity set to `normalizeQueryString: false` to disable this behavior - For numeric values, it converts `/page?id=123` to `/page?id=NUMBER` - For string values, it converts `/page?plan=premium` to `/page?plan=STRING` - When mixed values are present, it converts `/page?id=123&plan=premium` to `/page?id=NUMBER&plan=STRING`
manfromanotherland
force-pushed
the
ed-normalize-query-string
branch
from
4f82894 to
f4a4741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces query string improvements for Playwright tests, to reduce the number of distinct metrics a test run can generate and help users get more meaningful data out of a test.
stripQueryString: as seen in themetrics-by-endpointhttp plugin, query strings can now be removed — it defaults tofalsenormalizeQueryString: defaults totrue, prevents too many distinct metrics, can be explicitly set tofalseto disable this behavior/page?id=123to/page?id=NUMBER/page?plan=premiumto/page?plan=STRING/page?id=123&plan=premiumto/page?id=NUMBER&plan=STRINGPre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.