More invalid test vectors#6
Open
roconnor-blockstream wants to merge 708 commits intoapoelstra:masterfrom
Open
Conversation
BIP 370: Use PSBT_GLOBAL_FALLBACK_LOCKTIME in text
Before this change, repository gets detected as: Python 66.4% Go 12.9% Perl 11.0% TeX 8.1% Shell 1.6% After this change, repository gets detected as: Wikitext 97.2% Python 1.9% Other 0.9% This change was added for a cosmetic effect on GitHub, and the line this change adds can go away in any of these cases: * Conflict with other tool used for reading these documents. * GitHub ceases to use the line. * GitHub ceases to be used as a reading medium for these documents. * GitHub ceases to exist.
Make Wikitext linguist-detectable
BIPs 300/301 were 2 years old! I have updated, shortened, and clarified them.
BIPs 300/301 were 2 years old! I have updated, shortened, and clarified them.
* Pull the definition of the extension in BIP342 to its own section * Add a section to BIP341 on validating script path signatures * Clarify that SigMsg does not produce the message being signed, but a common portion of it
BIP 0174: Clarify use of PSBT_IN_FINAL_* when data is empty
Minor Updates to BIP-119
[BIP 157] Add missing words to sentence
BIP 0069: Fix broken link
Currently the BIP-341 and BIP-342 leave the question of how to verify signature for non-`0xC0` leaf version scripts undefined. I haven't checked the Bitcoin Core code for that matter yet, but (1) I think we need to cover signature validation of non-`0xC0` leaf version scripts in this standard and (2) the only way of doing that is "always succeed" rule for the future leaf version values (otherwise we will need a hard fork to introduce them).
BIP118: simplify explanation of signature message
BIP 341: add missing conversions between bytes and int
Changes/clarifications to bip-330.
[Trivial] BIP-70 Fixing sipa's gist proposal url
…l-fix bip-0011/12 - fixed broken implementation url
The reconciliation protocol assumes using one role consistently. Since it is irrelevant which one is which, we can imply that the initiator of the P2P connection will assume the role of reconciliation initiator. This protocol simplification will seep into the implementation.
`lift_x` returns `None` if the input integer is not an X coordinate on the curve to indicate failure. `point_add`, on the other hand, interprets `None` as the point at infinity. Therefore, without this commit, if the internal `pubkey` is not a valid X coordinate, the function will not fail, which contradicts the specification in the "Script validation rules section". Instead, it sets `Q` to `t*G`.
BIP330: drop redundant booleans from the sendtxrcncl message
BIP 341: Fix taproot_tweak_pubkey
BIP341: add aux_rand argument to taproot_sign_key
In contrast to taproot_output_script, taproot_sign_key was not able to deal with a script_tree that is None. This commit fixes taproot_sign_key such that it can sign for such outputs. This commit avoids changing the behavior of the functions except taproot_sign_key at the cost of having some code duplication. Alternatively, one could let taproot_tree_helper deal with a None script_tree directly.
BIP 341: allow taproot_sign_key with no script tree
Add BIP324: v2 P2P Transport Protocol
Includes: * Simpler (but equivalent) ElligatorSwift encoding function & spec * Improved test vectors * Test vector generation code * Code for converting test vectors for libsecp256k1 code. * Code for running test vectors against SwiftEC paper authors' code. * Miscellaneous reference code improvements (style, comments).
* initial commit * fix formatting * add importing section * clarify csv preference * tabs to spaces * add rationale and references, require that rfc4180 is followed * fix reference links * show reference links as list * use self describing json lines format instead of csv * add bip number and accommodate 65 byte pubkeys * fix comments uri
BIP174: s/uiht/uint/s
BIP324 reference code / test vector improvements
BIP0174 and BIP0370 PSBT_GLOBAL_TX_VERSION <valuedata> type correction
Using the identifier "faux" for invalid test vectors. Extending the set of example a little bit.
These examples are valid BIP-173 and BIP-350 strings (but not valid BIP-93 strings).
roconnor-blockstream
force-pushed
the
2023-03--volvelles
branch
from
b1d291a to
e24089e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These examples are valid BIP-173 and BIP-350 strings (but not valid BIP-93 strings).