FINERACT 2289:New command processing - Working Days #5261
Closed
+447
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
working days write service pipeline refactored update security config read service refactoring format spotless check validation fixes validation fixes2 fixing updateWorkingDaysTest update tests for auth and tenant based on security config, ran spotless and fixed style issues fixed updaterequest dto and removed generated fixed workingdaysupdaterequest to be backward compatible FINERACT-2289: Fixing working days integration test errors change test to original updated id to resourceId and tests are successful working days write service pipeline refactored update security config read service refactoring format spotless check validation fixes validation fixes2 fixing updateWorkingDaysTest update tests for auth and tenant based on security config, ran spotless and fixed style issues fixed updaterequest dto and removed generated fixed workingdaysupdaterequest to be backward compatible FINERACT-2289: Fixing working days integration test errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Refactoring the Working Days module as per the New Command Processing Infrastructure
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.